-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Plugin.createComponents method that specifies individual services #101457
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, of course when CI passes :)
(I see you added the serverless update test too, so this will cover all!)
I'd suggest a small change to the "breaking change" message. While it would be a breaking change for a lot of plugins, plugins aren't required to override Rather, I'd specify that it's a breaking change for any plugin that overrides I hope I'm not coming off as pedantic. Mainly I don't want to accidentally imply that we're breaking the stability guarantee for stable plugins when we're not actually doing that. |
I've tweaked the changelog wording |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remove the
createComponents
method that specifies individual services, in favour of thePluginServices
method.This is a breaking change for all plugin implementations; implementations should move to the
createComponents(PluginServices)
method